Issue34

Issue Title Allowed Flow-ID field combinations
Document: GIMPS Protocol Specification v05 Section: C.4.1
Category: Editorial Priority: Must Fix
Status: Closed

Created on 2005-03-09.20:17:19 by reh, last changed 2005-05-12.12:00:37.

Messages
msg126 Author: reh Date: 2005-05-12.12:00:36
Version -06 includes fixes for the typos, and is also more explicit about the
fact that certain fields are included only if the corresponding flags are set in
the initial word.

The object syntax still allows 'meaningless' MRIs to be constructed, for
example, setting both S (SPI) and A/B (port) flags, or setting S when the
protocol number is not one of the IPsec protocols. However, rather than trying
to pin down exactly what combinations are acceptable in the bit-level syntax, it
seems more reasonable to rely on 
a) common sense, and
b) helpful error messages which can be generated by an node receiving a
combination which it regards as unreasonable.
msg99 Author: reh Date: 2005-03-10.21:50:21
We should also consider whether the port fields should only be allowed if the IP
protocol number is something sensible (UDP, TCP and so on).
msg98 Author: reh Date: 2005-03-10.21:30:55
The text should also say that if the A/B, I flags are not set, the corresponding
words are absent in the body of the information element. (This is partly implied
by the text for A/B already.)
msg95 Author: reh Date: 2005-03-09.22:29:56
... and the text about one or other of A/B should really refer to A/B and not
S/D (which is old terminology...)
msg94 Author: reh Date: 2005-03-09.21:58:56
It would be helpful to clarify that if one but not the other A/B flags is set,
the bits in the ports field for the 'unset' port are treated as padding (i.e.
present but not significant).

more generally, it would be helpful to verify (and then state) that the parsing
interdependencies between different fields only affect the flag fields in the
initial word. once the set of flag fields has been checked for consistency, the
rest of the words in the object can be parsed independently.
msg93 Author: andrew Date: 2005-03-09.21:31:34
Now that "S" is no longer used as the Source Port flag, it might be logical to
use "S" instead of "I" for the SPI.
msg90 Author: reh Date: 2005-03-09.20:19:04
It is hard to think of a circumstance where it would be meaningful to specify
both of these, so the bit format should probably be fixed.

More generally, the flow-ID format needs to be checked to ensure that it
actually correctly reflects the set of possible meaningful combinations of
header fields that can be specified.
msg89 Author: reh Date: 2005-03-09.20:17:19
The current ABNF for the flow ID (MRI for path-coupled routing) disallows the
specification of both SPI and L4 ports. But the bit formats in C.4.1 allow both
at the same time, which is a contradiction.
History
Date User Action Args
2005-05-12 12:00:37rehsetstatus: Pending -> Closed
messages: + msg126
2005-03-10 21:50:21rehsetmessages: + msg99
2005-03-10 21:30:55rehsetmessages: + msg98
2005-03-09 22:29:56rehsetmessages: + msg95
2005-03-09 21:58:56rehsetmessages: + msg94
2005-03-09 21:31:34andrewsetmessages: + msg93
2005-03-09 20:19:04rehsetstatus: No Discussion -> Pending
messages: + msg90
2005-03-09 20:17:19rehcreate